From c25d8e3aea900f8ae2abd2907a5b8a2e89e7ee9e Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Thu, 28 Mar 2013 22:52:30 +0100 Subject: [PATCH] cssvalue: Handle named colors not resolving If a named color references a nonexistant named color, we didn't catch that error and ended up crashing on a NULL-dereference. This crashed Boxes, because its CSS referenced values from the theme that didn't exist in any theme. --- gtk/gtkcsscolorvalue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk/gtkcsscolorvalue.c b/gtk/gtkcsscolorvalue.c index 9ff0a05210..64933bde58 100644 --- a/gtk/gtkcsscolorvalue.c +++ b/gtk/gtkcsscolorvalue.c @@ -166,6 +166,8 @@ _gtk_css_color_value_resolve (GtkCssValue *color, return NULL; value = _gtk_css_color_value_resolve (named, provider, current, current_deps, dependencies); + if (value == NULL) + return NULL; } break; -- 2.30.2